[PATCH] small fix to selftest

Michael Adam obnox at samba.org
Wed Jul 23 09:40:10 MDT 2014


On 2014-07-23 at 17:15 +0200, Volker Lendecke wrote:
> On Wed, Jul 23, 2014 at 11:31:57AM +0200, Michael Adam wrote:
> > review / push / comments appreciated
> 
> What does it fix, what failed before?

With the orignal code I see "stat: ...no such file or directory"
from the call to $self->get_fs_specific_conf($shrdir),
because the mkdir is done later.

It does not break anything in my setup, but it logs error
messages and it probably fails to do the intended thing for
file systems (currently only btrfs).

If you are implying that I should have made that more
clear in the commit message... you are right!

Cheers - Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140723/c44fcac9/attachment.pgp>


More information about the samba-technical mailing list