SMB3 Multi-Channel (Re: What I'm working on)
Volker.Lendecke at SerNet.DE
Wed Jul 23 08:32:31 MDT 2014
On Mon, Jul 21, 2014 at 08:36:37PM +0200, Stefan (metze) Metzmacher wrote:
> I just removed it as it wasn't needed at all.
> I also introduced a 'const char 'smbXsrv_connection_dbg(const struct
> smbXsrv_connection *xconn)'
> similar to fsp_fnum_dbg() and fsp_str_dbg().
> The commits with TODO/REVIEW are the chance which where added or modified.
Attached find my reviews. Almost all look good, I've just
amended very few commit messages with questions. Also, I've
added 3 related cleanup patches that you might want to
review while you're looking at it.
The one with the sendfile destructor setting *pstatus is a
bit ugly, but so is sendfile I guess..
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 52741 bytes
Desc: not available
More information about the samba-technical