SMB3 Multi-Channel (Re: What I'm working on)
Volker.Lendecke at SerNet.DE
Wed Jul 23 06:13:31 MDT 2014
On Mon, Jul 21, 2014 at 08:36:37PM +0200, Stefan (metze) Metzmacher wrote:
> I just removed it as it wasn't needed at all.
> I also introduced a 'const char 'smbXsrv_connection_dbg(const struct
> smbXsrv_connection *xconn)'
> similar to fsp_fnum_dbg() and fsp_str_dbg().
> The commits with TODO/REVIEW are the chance which where added or modified.
One broader question: You move a lot of stuff from
smbd_server_connection to smbXsrv_connection, and I have
reviewed most of that already. If I understand it correctly,
smbXsrv_connection is going to be per TCP connection. Under
this assumption I ask myself whether it really makes sense
to migrate everything for SMB1 there that will definitely
only exist once per client machine, there won't be any multi
channel over SMB1. Also, it adds burden to every incoming
SMB2 TCP connection. First, there is negligible memory
overhead, but also from a clarity point of view I would like
to raise the question whether we need something that won't
ever have more than one instance per client machine. With
the smbXsrv_connection this is a bit blurred to me as a
casual reader of this.
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
More information about the samba-technical