[PATCH] s4-dns: dlz-bind9: Continue lookup if error on multivalued record types

Amitay Isaacs amitay at gmail.com
Tue Jul 22 22:32:26 MDT 2014

On Mon, Jul 21, 2014 at 8:59 PM, Kamen Mazdrashki <kamenim at samba.org> wrote:

> On Wed, Jul 16, 2014 at 7:11 PM, Samuel Cabrero <scabrero at zentyal.com>
> wrote:
>> Hi,
>> I have finished with the WINS and WINS-R record support for the internal
>> DNS server, including the RPC interface, regular DNS queries and tests for
>> both of them. Please let me know if there is something wrong with it.
>> Looks good to me.
> Reviewed-by: Kamen Mazdrashki <kamenim at samba.org>
> Kai, Amitay, could you please take look at patches if they are OK?
> Regards,
> Kamen

Hi Samuel,

Thanks for the implementation of wins records in DNS.  It's looking good.
However there seems to be some confusion regarding multiple dns related idl
files. :-)

Currently we do have some duplication of DNS structures.  Here is an
explanation for where idl files are used.

   dnsp.idl         - original partial implementation of MS_DNSP with focus
only on resource records.  This is used in python scripts.
   dns.idl           - DNS server implementation (using auto-generated
marshaling routines)
   dnsserver.idl   - RPC dns server

You might be able to adjust your patches better with this explanation.  I
have included comments on patches for clarity.

4. idl: dnsp: Add dnsp_wins and dnsp_winsr data types for WINS and WINSR

Either include all idl changes in a single patch, or keep the changes in
IDL and related code in a single patch.  So dnsp.idl changes should go with
netcmd/dns.py changes.

5. s4-dns: Support WINS and WINS-R records queries over RPC

This patch should only include dnsserver.idl and not dns.idl.  You might
want to keep the code changes in rpc_server/dnsserver/dns_data.c with this.

6. s4-dns: Support WINS and WINS-R dns queries

This patch should include changes to dns.idl

7. s4-rpc: dnsserver: Support WINS and WINS-R records

As I mentioned previously, dnsserver.idl changes can be combined with this

8. dns: Extend tests for WINS and WINS-R records

The tests are explicitly querying for WINS records, but are not querying
for SOA records in presence of WINS records.  As I understood, that is the
scenario which was not working.  We should also add a test that fails with
current code, but works with your fixes.

Also, you are missing the implementation of netcmd.dns.WINSRecord and
netcmd.dns.WINSRRecord classes.  May be you forgot to include that patch?


More information about the samba-technical mailing list