[PATCH] s4-dns: dlz-bind9: Continue lookup if error on multivalued record types
kamenim at samba.org
Mon Jul 21 04:59:30 MDT 2014
On Wed, Jul 16, 2014 at 7:11 PM, Samuel Cabrero <scabrero at zentyal.com>
> I have finished with the WINS and WINS-R record support for the internal
> DNS server, including the RPC interface, regular DNS queries and tests for
> both of them. Please let me know if there is something wrong with it.
> Looks good to me.
Reviewed-by: Kamen Mazdrashki <kamenim at samba.org>
Kai, Amitay, could you please take look at patches if they are OK?
> On 15/07/14 03:53, Amitay Isaacs wrote:
>> Hi Samuel,
>> On Fri, Jul 11, 2014 at 2:07 AM, Samuel Cabrero <scabrero at zentyal.com
>> <mailto:scabrero at zentyal.com>> wrote:
>> Hi Amitay,
>> I have extended the patch to catch it, together with a couple of
>> talloc contexts not freed.
>> That's much better. Thanks.
>> On 10/07/14 11:11, Amitay Isaacs wrote:
>> On Thu, Jul 10, 2014 at 1:14 AM, Samuel Cabrero
>> <scabrero at zentyal.com <mailto:scabrero at zentyal.com>
>> <mailto:scabrero at zentyal.com <mailto:scabrero at zentyal.com>>>
>> we have a report about bind dlz not being able to load a
>> zone which
>> have a WINS record type defined. Having a look to the code,
>> lookup abort on multivalued record types as soon as it
>> finds a not
>> supported record type, so when the dlz is loading the zone
>> and query
>> the zone root (@), if the WINS record is returned by ldb
>> before the SOA record bind complains with "zone
>> xxxxxx.xxx/NONE: has
>> 0 SOA records" and does not start.
>> This patch makes the lookup operation to continue on errors,
>> problematic records are logged and skipped.
>> The patch does not look complete. If the zone only has WINS
>> type record
>> and no SOA record, then the code will return success when it falls
>> through the loop.
>> As Kai mentioned before, it would be good to add a test with WINS record
>> to make sure internal dns server and dns rpc server work correctly.
>> Can you add a test or provide sample of a valid WINS record?
> Samuel Cabrero - Developer
> scabrero at zentyal.com
> Zentyal - Active Exchange
More information about the samba-technical