Stefan (metze) Metzmacher
metze at samba.org
Thu Jul 17 08:46:17 MDT 2014
>> > >If you'd like to change that, and have the third party stuff somewhere
>>>> else, can we please call that "third_party/" ? "Libraries" is also
>>>> a misleading name since some of the third party stuff we bundle are
>>>> things like Python modules.
>>> To be honest, I don't care much about lib/ or not, but _3p was
>>> drastically non-obvious to me. The subject looked like the patches
>>> were about a possibly vendor-specific file system or the like
>>> (storage products like 3par would come to mind).
>>> It's not like the few extra characters cost a lot of bandwidth :)
>> Same here, I was puzzled about 3p until I read down in the thread. :-)
> Ok, request to change name ACKed. It takes a few requests for me to ACK a
> name change in particular because they tend to be bike shed discussions.
> Once I can see a clear consensus, and reasons from more than one person...
> I'll make a change.
> - I think it should _not_ go under ./lib/ (see above).
>> - My current vote would be for "./thirdparty/
> We are inconsistent with what we call things as far as using a '_', '-', or
> nothing at all. Alas, that is a bit of a pain.
> I'm going to be arbitrary, and say we all lose. third-party it is!
> The reason behind the - is quite simple... samba-third-party-4.2.10.tar
> just reads right.
I'm not yet convinced that we should remove /thirdparty/ from our master
> Due to the name change I'll restructure the commits, to be more clear,
> though it'll result in much more churn, the goal of the changes will be
> highlight the build system changes to support the changes. Review should
> be much easier even if you can't deal with the large moves etc.
I'm fine with moving things to that directory, if you do it in small
moving one thing at a time.
Please wait for my explicit ack for any patches to master.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 246 bytes
Desc: OpenPGP digital signature
More information about the samba-technical