[PATCH v3] New VFS module vfs_fruit

Jeremy Allison jra at samba.org
Wed Jul 16 16:28:04 MDT 2014


On Wed, Jul 09, 2014 at 07:30:05PM +0200, Ralph Böhme wrote:
> Hi
> 
> here's an updated patch series incorporating Jeremy's feedback and an
> adding selftest/smbtorture test.
> 
> Review appreciated.

Compile errors after applying to current master:

../source3/modules/vfs_fruit.c: In function ‘adouble_path’:
../source3/modules/vfs_fruit.c:1241:14: warning: declaration of ‘basename’ shadows a global declaration [-Wshadow]
../source3/modules/vfs_fruit.c: In function ‘access_to_netatalk_brl’:
../source3/modules/vfs_fruit.c:1427:53: warning: declaration of ‘fork’ shadows a global declaration [-Wshadow]
../source3/modules/vfs_fruit.c: In function ‘denymode_to_netatalk_brl’:
../source3/modules/vfs_fruit.c:1461:55: warning: declaration of ‘fork’ shadows a global declaration [-Wshadow]
../source3/modules/vfs_fruit.c: In function ‘fruit_check_access’:
../source3/modules/vfs_fruit.c:1524:18: warning: declaration of ‘fork’ shadows a global declaration [-Wshadow]
../source3/modules/vfs_fruit.c:1560:5: error: too many arguments to function ‘do_lock’
../source3/locking/proto.h:123:25: note: declared here
../source3/modules/vfs_fruit.c:1574:5: error: too many arguments to function ‘do_lock’
../source3/locking/proto.h:123:25: note: declared here
../source3/modules/vfs_fruit.c:1610:5: error: too many arguments to function ‘do_lock’
../source3/locking/proto.h:123:25: note: declared here
../source3/modules/vfs_fruit.c:1624:5: error: too many arguments to function ‘do_lock’
../source3/locking/proto.h:123:25: note: declared here

Can you fix these up as well please ?

Thanks !

Jeremy.


More information about the samba-technical mailing list