[PATCH] s4-dns: dlz-bind9: Continue lookup if error on multivalued record types

[Samuel Cabrero]

Hi,

I have finished with the WINS and WINS-R record support for the internal 
DNS server, including the RPC interface, regular DNS queries and tests 
for both of them. Please let me know if there is something wrong with it.

Samuel.

On 15/07/14 03:53, Amitay Isaacs wrote:
> Hi Samuel,
>
> On Fri, Jul 11, 2014 at 2:07 AM, Samuel Cabrero <scabrero at zentyal.com
> <mailto:scabrero at zentyal.com>> wrote:
>
>     Hi Amitay,
>
>     I have extended the patch to catch it, together with a couple of
>     talloc contexts not freed.
>
>     Cheers.
>
>
> That's much better. Thanks.
>
>
>     On 10/07/14 11:11, Amitay Isaacs wrote:
>
>         On Thu, Jul 10, 2014 at 1:14 AM, Samuel Cabrero
>         <scabrero at zentyal.com <mailto:scabrero at zentyal.com>
>         <mailto:scabrero at zentyal.com <mailto:scabrero at zentyal.com>>> wrote:
>
>              Hi,
>
>              we have a report about bind dlz not being able to load a
>         zone which
>              have a WINS record type defined. Having a look to the code, the
>              lookup abort on multivalued record types as soon as it
>         finds a not
>              supported record type, so when the dlz is loading the zone
>         and query
>              the zone root (@), if the WINS record is returned by ldb search
>              before the SOA record bind complains with "zone
>         xxxxxx.xxx/NONE: has
>              0 SOA records" and does not start.
>
>              This patch makes the lookup operation to continue on errors, so
>              problematic records are logged and skipped.
>
>
>         The patch does not look complete.  If the zone only has WINS
>         type record
>         and no SOA record, then the code will return success when it falls
>         through the loop.
>
>         Amitay.
>
>
> As Kai mentioned before, it would be good to add a test with WINS record
> to make sure internal dns server and dns rpc server work correctly.
>
> Can you add a test or provide sample of a valid WINS record?
>
> Amitay.

-- 
Samuel Cabrero - Developer
scabrero at zentyal.com

Zentyal - Active Exchange
www.zentyal.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0009-dns-Extend-tests-for-WINS-and-WINS-R-records.patch
Type: text/x-patch
Size: 7315 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140716/19d442a4/attachment-0009.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-dns.py-Support-WINS-and-WINS-R-record-management.patch
Type: text/x-patch
Size: 7720 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140716/19d442a4/attachment-0010.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-s4-rpc-dnsserver-Support-WINS-and-WINS-R-records.patch
Type: text/x-patch
Size: 4402 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140716/19d442a4/attachment-0011.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-s4-dns-Support-WINS-and-WINS-R-dns-queries.patch
Type: text/x-patch
Size: 1891 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140716/19d442a4/attachment-0012.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-s4-dns-Support-WINS-and-WINS-R-records-queries-over-.patch
Type: text/x-patch
Size: 4930 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140716/19d442a4/attachment-0013.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-idl-dnsp-Add-dnsp_wins-and-dnsp_winsr-data-types-for.patch
Type: text/x-patch
Size: 1856 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140716/19d442a4/attachment-0014.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-s4-dns-dlz-bind9-Return-success-only-if-at-least-one.patch
Type: text/x-patch
Size: 1293 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140716/19d442a4/attachment-0015.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-s4-dns-dlz-bind9-Fix-talloc-contexts-not-freed.patch
Type: text/x-patch
Size: 1575 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140716/19d442a4/attachment-0016.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s4-dns-dlz-bind9-Continue-lookup-if-error-on-multiva.patch
Type: text/x-patch
Size: 1451 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140716/19d442a4/attachment-0017.bin>