[SCM] Samba Shared Repository - branch master updated

[Jeremy Allison]

On Thu, Jul 10, 2014 at 01:24:00AM +0200, Michael Adam wrote:
> Hi Andrew,
> 
> since I just looked at this in bugzilla, one question:
> 
> On 2014-04-02 at 02:37 +0200, Jeremy Allison wrote:
> > The branch, master has been updated
> >        ...
> >        via  bc5bd40 libsmb: Provide a talloc_stackframe() to external users of libsmb_setget.c
> >        ...
> > 
> > http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> 
> In this commit:
> 
> > - Log -----------------------------------------------------------------
> > commit bc5bd4010e8fedf19047ed6f7a793cd373f9f14f
> > Author: Andrew Bartlett <abartlet at samba.org>
> > Date:   Mon Mar 31 10:19:58 2014 +1300
> > 
> >     libsmb: Provide a talloc_stackframe() to external users of libsmb_setget.c
> >     
> >     Signed-off-by: Andrew Bartlett <abartlet at samba.org>
> >     Reviewed-by: Jeremy Allison <jra at samba.org>
> 
> Isn't this hunk superfluous?

Yes :-).

> Just returning a variable doesn't require a talloc stackframe,
> or what am I missing?
> 
> Feel free to push the attached patch to revert this part.
> 
> Looking at the code, I get the impression that the other
> hunks are not needed either currently, but these
> call functions and those may change, and I see the point there.

Ok, it's a fair cop. This function doesn't need it,
but you could argue that it's good practice to have
this boilerplate on every entry/exit from that library,
but yeah - in this specific case it's not needed.

Jeremy.