Patch to remove zlib.

Ira Cooper ira at samba.org
Tue Jul 15 14:37:56 MDT 2014


On Tue, Jul 15, 2014 at 3:02 PM, Volker Lendecke <Volker.Lendecke at sernet.de>
wrote:

> On Tue, Jul 15, 2014 at 07:22:59PM +0200, Jelmer Vernooij wrote:
> > On Tue, Jul 15, 2014 at 09:13:22AM +0200, Andreas Schneider wrote:
> > > On Friday 11 July 2014 07:53:04 Ira Cooper wrote:
> > > > Then iniparser.  (Which if someone wants to replace with code that
> does not
> > > > suck, I'll let that person do.  Frankly, anything that moves us
> closer to
> > > > not using it is a win.)
> > > > Then popt.
> > >
> > > I got a NAK some time ago for this code:
> > >
> > >
> https://git.samba.org/?p=asn/samba.git;a=shortlog;h=refs/heads/config_parser
> >
> > This looks good to me in general, but we already have a generic
> > iniconf parser in lib/param/generic.c. It uses the lexer from
> > loadparm.
>
> Also -- iniparser is only used in pam_winbind. Why that at
> all? Why not use normal arguments from pam.conf like
> use_first_pass?
>

It is also used in source3/utils/ntlm_auth.c.  Looks like we create our own
little pam config file etc...

Thanks,

-Ira


More information about the samba-technical mailing list