Removal of zlib, take 2.

Jelmer Vernooij jelmer at samba.org
Tue Jul 15 10:07:07 MDT 2014


On Tue, Jul 15, 2014 at 11:58:03AM -0400, Ira Cooper wrote:
> Code for review is at:
> http://git.samba.org/?p=ira/wip.git;a=shortlog;h=refs/heads/zlib_removal
> 
> This is the "remove zlib, and break all systems without zlib" version.
This still uses CHECK_BUNDLED_SYSTEM, which is the wrong function for
libraries that are not bundled.

> I copied the configure check used previously, so it should detect libraries
> the exact same way we do today, just to avoid any issues with botching the
> check.
> 
> Regarding making zlib truly optional:  I've made good progress on this
> front, but the patch is substantially more complex, because I didn't fully
> listen to Volker ;).  I also conditionalized zlib in the AD DC.  It looks
> "plausible" that it should work, but I don't know the right tests to run,
> nor have a test environment of that type setup.  So I'd like some
> assistance in getting those patches properly tested.
Does "make test" still pass without zlib installed on the system?

Cheers,

Jelmer

-- 
Jelmer Vernooij <jelmer at samba.org> - https://jelmer.co.uk/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140715/87773b86/attachment.pgp>


More information about the samba-technical mailing list