[PATCHES] fix flapping offline flag in gpfs module

Christof Schmitt cs at samba.org
Thu Jul 10 11:46:38 MDT 2014


On Thu, Jul 10, 2014 at 10:54:30AM +0200, Volker Lendecke wrote:
> On Thu, Jul 10, 2014 at 12:38:43AM +0200, Michael Adam wrote:
> > There is this awful problem of the flapping offline flag
> > when using the gpfs module and "gpfs:winattr = yes".
> > It was pretty clear since a time that this must be due
> > to uninitialized data (where the winattrs are stored),
> > i.e. the vfs_private in the struct stat_ex.
> 
> As discussed offline with Michael: I think with patch 2/4
> vfs_private is not referenced at all anymore. vfs_private is
> a broken concept once more than one VFS module starts using
> it. IMHO it should go.

Other parts of the vfs_gpfs module still access the vfs_private. I agree
that it should go, we just have to replace it with a FSP_EXTENSION.

Christof


More information about the samba-technical mailing list