[PATCH] s4-dns: dlz-bind9: Continue lookup if error on multivalued record types

[Samuel Cabrero]

Hi Amitay,

I have extended the patch to catch it, together with a couple of talloc 
contexts not freed.

Cheers.

On 10/07/14 11:11, Amitay Isaacs wrote:
> On Thu, Jul 10, 2014 at 1:14 AM, Samuel Cabrero <scabrero at zentyal.com
> <mailto:scabrero at zentyal.com>> wrote:
>
>     Hi,
>
>     we have a report about bind dlz not being able to load a zone which
>     have a WINS record type defined. Having a look to the code, the
>     lookup abort on multivalued record types as soon as it finds a not
>     supported record type, so when the dlz is loading the zone and query
>     the zone root (@), if the WINS record is returned by ldb search
>     before the SOA record bind complains with "zone xxxxxx.xxx/NONE: has
>     0 SOA records" and does not start.
>
>     This patch makes the lookup operation to continue on errors, so
>     problematic records are logged and skipped.
>
>
> The patch does not look complete.  If the zone only has WINS type record
> and no SOA record, then the code will return success when it falls
> through the loop.
>
> Amitay.

-- 
Samuel Cabrero - Developer
scabrero at zentyal.com

Zentyal - Active Exchange
www.zentyal.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-s4-dns-dlz-bind9-Return-success-only-if-at-least-one-record-sent.patch
Type: text/x-patch
Size: 1293 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140710/2e9d1614/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-s4-dns-dlz-bind9-Fix-talloc-contexts-not-freed.patch
Type: text/x-patch
Size: 1575 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140710/2e9d1614/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s4-dns-dlz-bind9-Continue-lookup-if-error-on-multivalued-record-types.patch
Type: text/x-patch
Size: 1451 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140710/2e9d1614/attachment-0002.bin>