[PATCH] Add ntlm_auth require-membership-of tests
kamenim at samba.org
Thu Jul 10 05:40:46 MDT 2014
Could you please fix leading white spaces in test_ntlm_auth_s3.sh
As far as I can see, we are using TAB in sh files also.
Other that that, patch looks good to be
Reviewed-by: Kamen Mazdrashki <kamenim at samba.org>
On Thu, Jul 10, 2014 at 12:06 PM, Andrew Bartlett <abartlet at samba.org>
> On Fri, 2014-07-04 at 14:31 +1200, Garming Sam wrote:
> > Hi,
> > Attached are some patches to try to add some testing for the
> > require-membership-of option for ntlm_auth.
> > The first patch just adds a require-membership-of option to
> > test_ntlm_auth.py. The second uses it for testing and also performs a
> > test with an interactive prompt.
> > Please review.
> I've reviewed these patches, but I still need a second team reviewer.
> Can I please have that, so we can get this important test of this
> important behaviour into master?
> Andrew Bartlett
> Andrew Bartlett http://samba.org/~abartlet/
> Authentication Developer, Samba Team http://samba.org
> Samba Developer, Catalyst IT
More information about the samba-technical