[PATCH] Add ntlm_auth require-membership-of tests

Kamen Mazdrashki kamenim at samba.org
Thu Jul 10 05:40:46 MDT 2014


Hi Garmin,

Could you please fix leading white spaces in test_ntlm_auth_s3.sh
As far as I can see, we are using TAB in sh files also.

Other that that, patch looks good to be
Reviewed-by: Kamen Mazdrashki <kamenim at samba.org>

Cheers,
Kamen



On Thu, Jul 10, 2014 at 12:06 PM, Andrew Bartlett <abartlet at samba.org>
wrote:

> On Fri, 2014-07-04 at 14:31 +1200, Garming Sam wrote:
> > Hi,
> >
> > Attached are some patches to try to add some testing for the
> > require-membership-of option for ntlm_auth.
> >
> > The first patch just adds a require-membership-of option to
> > test_ntlm_auth.py. The second uses it for testing and also performs a
> > test with an interactive prompt.
> >
> >
> > Please review.
>
> G'Day,
>
> I've reviewed these patches, but I still need a second team reviewer.
> Can I please have that, so we can get this important test of this
> important behaviour into master?
>
> Thanks,
>
> Andrew Bartlett
>
> --
> Andrew Bartlett                       http://samba.org/~abartlet/
> Authentication Developer, Samba Team  http://samba.org
> Samba Developer, Catalyst IT
> http://catalyst.net.nz/services/samba
>
>
>


More information about the samba-technical mailing list