Patch to remove zlib.
jelmer at samba.org
Wed Jul 9 09:01:45 MDT 2014
On Mon, Jul 07, 2014 at 12:46:47PM -0400, Ira Cooper wrote:
> Note: To apply it unxz it then use git am --ignore-whitespace , otherwise
> you may have issues. (xz was used to save the list a good bit of space...
> it's over 500k gzipped.)
> As far as why: I listened to metze/vl. I disagree with them.
> I believe that third party (non Samba Team developed) libraries do not
> belong in the tree. They are asking for trouble long term, IMHO.
> Consider this patch the first step down the path to cleaning up these
Thanks for working on this. It'd be great to always rely on the system zlib.
It reduces some overhead on us to support two configurations in waf (one with
the bundled zlib and one with the system zlib), and keeping the zlib copy up to
date. This is not a huge burden, but all the little bits help. :-)
You probably want to use something other than CHECK_BUNDLED_SYSTEM() to
detect zlib, since zlib is no longer bundled. CHECK_BUNDLED_SYSTEM() also
relies exclusively on pkg-config (at least so its docstring claims) to find
zlib; are we ready to make pkg-config a mandatory dependency?
More information about the samba-technical