[PATCH] vfs module for VxFS
Abhidnya_Joshi at symantec.com
Wed Jul 9 04:00:36 MDT 2014
Thanks for the quick response! Yes I will create patch for samba 4.1.
I agree that this can be converted to generic xattr rename module but we are also planning subsequent changes to ACL handling specific to VxFS.
And these will go under this module.
May be I can combine all the changes and send the multiple patches together.
Thanks and Regards
From: Volker Lendecke [mailto:Volker.Lendecke at SerNet.DE]
Sent: Wednesday, July 09, 2014 3:13 PM
To: Abhidnya Joshi
Cc: samba-technical at samba.org
Subject: Re: [PATCH] vfs module for VxFS
On Wed, Jul 09, 2014 at 02:30:50AM -0700, Abhidnya Joshi wrote:
> Hi List,
> As part of our NAS product, we are using Samba on top of Symantec File System (VxFS).
> We are making use of acl_xattr module to interpret and store NTACLs.
> Presently VxFS does not support security namespace for named attrs thus, NTACLs have to be stored under user.NTACL.
> Its use will be vfs objects = acl_xattr vxfs
> Please find attached patch which adds new module for VxFS which can handle this.
> Also we are planning few more additions to this module with respect to NTACL to POSIX ACL handling which I will post once ready.
> This patch applies to Samba 3.6.23. Please let me know reviews/comments.
Hmm. First, 3.6.23 is not really open for this kind of change anymore, it is security fixes only. For upstream I'd recommend working on the master branch, possibly 4.1.
On the code: This looks not really vxfs specific to me. It's a general xattr renaming module, right? Maybe we can generalize that a bit? If vxfs comes along with more specific stuff like special APIs for NFS4 acls, posix acls or something similar, a vxfs module would certainly be appropriate.
Also, this seems to miss the listxattr call. Not sure it's actually used for this type of xattr, but for completeness I'd like to see the reverse mapping disk->samba as well.
With best regards,
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9 AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen http://www.sernet.de, mailto:kontakt at sernet.de
More information about the samba-technical