autobuild ctdb cleanup

Stefan (metze) Metzmacher metze at samba.org
Mon Jul 7 17:25:04 MDT 2014


Hi Amitay,

>> I noticed that there's a lot of ctdb and ctdb_reco processes
>> left after an autobuild (maybe only failed once).
>>
>> Could you take a look at that and may implement something like
>> the smbd_stdin_handler in source3/smbd/server.c.
>> So that ctdb can be started in foreground and exit when the parent went
>> away.
>>
>> Thanks!
>> metze
>>
>>
> Hi metze,
> 
> There is already logic in ctdb to clean up child processes if the main
> daemon goes away.  The problem here is of shutting down the local ctdb
> daemons when autobuild.py terminates abnormally.

Samba has the same cleanup method for both cases...

> Here's a patch that shuts down the local daemons started for test if the
> run_tests.sh script is sent SIGINT or SIGTERM.  I have tested it by running
> autobuild.py and then pressing Ctrl-C. This sends SIGTERM to run_tests.sh
> and shuts down the local daemons.  So as long as autobuild.py terminates
> the child processes, this would work.

Lets give it a try and please push it with my review.

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 246 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140708/3a84313b/attachment.pgp>


More information about the samba-technical mailing list