[PATCH 08/10] s4-backupkey: fix ndr_pull error on empty input

Arvid Requate requate at univention.de
Mon Jul 7 11:15:09 MDT 2014


[MS-BKRP] 3.1.4.1 specifies for BACKUPKEY_RETRIEVE_BACKUP_KEY_GUID that
the server must ignore the input data. This patch fixes
  ndr_pull_error(11): Pull bytes 4 (../librpc/ndr/ndr_basic.c:148)

Signed-off-by: Arvid Requate <requate at univention.de>
---
 librpc/idl/backupkey.idl | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/librpc/idl/backupkey.idl b/librpc/idl/backupkey.idl
index e21030b..b504ca5 100644
--- a/librpc/idl/backupkey.idl
+++ b/librpc/idl/backupkey.idl
@@ -47,6 +47,9 @@ interface backupkey
                uint8 key[256];
        } bkrp_dc_serverwrap_key;
 
+       [public] typedef struct {
+       } bkrp_empty;
+
        [public,gensize] typedef struct {
                uint32 version;
                uint32 encrypted_secret_len;
@@ -103,7 +106,7 @@ interface backupkey
 
        [public] typedef [nodiscriminant] union {
                [case(BACKUPKEY_RESTORE_GUID_INTEGER)] 
bkrp_client_side_wrapped restore_req;
-               [case(BACKUPKEY_RETRIEVE_BACKUP_KEY_GUID_INTEGER)] 
bkrp_client_side_wrapped cert_req;
+               [case(BACKUPKEY_RETRIEVE_BACKUP_KEY_GUID_INTEGER)] bkrp_empty 
empty;
        } bkrp_data_in_blob;
 
        /******************/
-- 
2.0.0.rc2



More information about the samba-technical mailing list