[PATCH 03/10] s4-backupkey: check for talloc failure

Arvid Requate requate at univention.de
Mon Jul 7 11:14:41 MDT 2014


Check for talloc_memdup failure for uniqueid.data.

Signed-off-by: Arvid Requate <requate at univention.de>
---
 source4/rpc_server/backupkey/dcesrv_backupkey.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/source4/rpc_server/backupkey/dcesrv_backupkey.c 
b/source4/rpc_server/backupkey/dcesrv_backupkey.c
index 50ceeeb..cc3c76b 100644
--- a/source4/rpc_server/backupkey/dcesrv_backupkey.c
+++ b/source4/rpc_server/backupkey/dcesrv_backupkey.c
@@ -836,6 +836,9 @@ static WERROR self_sign_cert(TALLOC_CTX *ctx, 
hx509_context *hctx, hx509_request
        int ret;
 
        uniqueid.data = talloc_memdup(ctx, guidblob->data, guidblob->length);
+       if (uniqueid.data == NULL) {
+               return WERR_NOMEM;
+       }
        /* uniqueid is a bit string in which each byte represent 1 bit (1 or 
0)
         * so as 1 byte is 8 bits we need to provision 8 times more space as 
in the
         * blob
-- 
2.0.0.rc2



More information about the samba-technical mailing list