[PATCH 25/37] param: replace lp_set_cmdline in s3 helpers to store_cmdline

[Andreas Schneider]

On Monday 07 July 2014 15:17:36 Andrew Bartlett wrote:
> On Mon, 2014-07-07 at 15:01 +1200, Garming Sam wrote:
> > Hi,
> > 
> > I've found the cause of the issue, which was that the command-line
> > parametric options weren't being overridden correctly. The new patch
> > gets rid of special casing which caused the problem in the first
> > place.
> > 
> > The rest of the patches which were reviewed remain the same, it's just
> > these two patches which have changed and actually need to be
> > re-reviewed.
> > 
> > Patches changed:
> > param: replace lp_set_cmdline in s3 helpers to store_cmdline
> > param: Amend docs.py test to check dumping of flagged parameters
> > 
> > The extra test added for docs.py was also amended.
> > 
> > 
> > http://git.catalyst.net.nz/gitweb?p=samba.git;a=shortlog;h=refs/heads/befo
> > re-service-ptrs-review3 git://git.catalyst.net.nz/samba.git
> > 			before-service-ptrs-review3
> Reviewed-by: Andrew Bartlett <abartlet at samba.org>
> 
> Can I have another team reviewer of these two:
> http://git.catalyst.net.nz/gitweb?p=samba.git;a=commitdiff;h=485603b8294f0d7
> 561ccda42dfd807646b89b9e4
> http://git.catalyst.net.nz/gitweb?p=samba.git;a=commitdiff;h=9f2696129e8e71
> 59e9346b6c940b7783f75de819
> 
> Thanks!
> 

RB+


	-- andreas

-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org