[PATCH 25/37] param: replace lp_set_cmdline in s3 helpers to store_cmdline

Andrew Bartlett abartlet at samba.org
Sun Jul 6 21:17:36 MDT 2014

On Mon, 2014-07-07 at 15:01 +1200, Garming Sam wrote:
> Hi,
> I've found the cause of the issue, which was that the command-line
> parametric options weren't being overridden correctly. The new patch
> gets rid of special casing which caused the problem in the first
> place. 
> The rest of the patches which were reviewed remain the same, it's just
> these two patches which have changed and actually need to be
> re-reviewed. 
> Patches changed: 
> param: replace lp_set_cmdline in s3 helpers to store_cmdline
> param: Amend docs.py test to check dumping of flagged parameters
> The extra test added for docs.py was also amended.
> http://git.catalyst.net.nz/gitweb?p=samba.git;a=shortlog;h=refs/heads/before-service-ptrs-review3
> git://git.catalyst.net.nz/samba.git 			before-service-ptrs-review3

Reviewed-by: Andrew Bartlett <abartlet at samba.org>

Can I have another team reviewer of these two:


(I still have a record of the other reviews done, and will apply those
tags before pushing). 

Andrew Bartlett
Andrew Bartlett
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list