[PATCH 25/37] param: replace lp_set_cmdline in s3 helpers to store_cmdline

[Garming Sam]

Hi,

I've found the cause of the issue, which was that the command-line 
parametric options weren't being overridden correctly. The new patch 
gets rid of special casing which caused the problem in the first place.

The rest of the patches which were reviewed remain the same, it's just 
these two patches which have changed and actually need to be re-reviewed.

Patches changed:
param: replace lp_set_cmdline in s3 helpers to store_cmdline
param: Amend docs.py test to check dumping of flagged parameters

The extra test added for docs.py was also amended.


http://git.catalyst.net.nz/gitweb?p=samba.git;a=shortlog;h=refs/heads/before-service-ptrs-review3

git://git.catalyst.net.nz/samba.git 			before-service-ptrs-review3



Cheers,

Garming Sam


On 05/07/14 20:39, Andrew Bartlett wrote:
> On Fri, 2014-06-20 at 23:47 +1200, abartlet at samba.org wrote:
>> From: Garming Sam <garming at catalyst.net.nz>
>>
>> Change-Id: I9a6ac66eeb8e0dd9ba356f5201f7ac09784b476d
>> Signed-off-by: Garming Sam <garming at catalyst.net.nz>
>> Reviewed-by: Andrew Bartlett <abartlet at samba.org>
> Garming,
>
> Sadly this patch seems to break the samba.tests.posixacl test (I
> bisected the failed autobuild).
>
> I guess we need to look at adding parametric options to the docs.py
> test.
>
> Sorry,
> (as I know you were really hoping to be past this loadparm work)
>
> Andrew Bartlett
>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-param-replace-lp_set_cmdline-in-s3-helpers-to-store_.patch
Type: text/x-patch
Size: 5300 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140707/4fa98cfa/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-param-Amend-docs.py-test-to-check-dumping-of-flagged.patch
Type: text/x-patch
Size: 5603 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140707/4fa98cfa/attachment-0001.bin>