[PATCHES] Merge loadparm further

Nadezhda Ivanova nivanova at samba.org
Fri Jul 4 07:22:17 MDT 2014

Hi Garming and Andrew,
Thanks for adding the test! I have reviewed all the patches in the
branch, stating from "param: ensure CMD_LIST is freed when freeing a
parameter" to the last one, and they look fine to me.

Reviewed-by: Nadezhda Ivanova <nivanova at samba.org>

On Thu, Jul 3, 2014 at 10:42 AM, Andrew Bartlett <abartlet at samba.org> wrote:
> On Thu, 2014-07-03 at 18:17 +1200, Garming Sam wrote:
>> Hi,
>> I've added an additional patch to the set of loadparm patches to attempt
>> to ensure that the flags and the display of defaults are correct.
>> What the patch does is extend the docs.py tests, with an empty smb.conf
>> test and with an overriding smb.conf defaults test.
>> git://git.catalyst.net.nz/samba.git before-service-ptrs-review2
>> http://git.catalyst.net.nz/gitweb?p=samba.git;a=shortlog;h=refs/heads/before-service-ptrs-review2
> Thanks Garming, this gives me much more confidence in the patch series.
> While bugs are always possible, loadparm has never been this well tested
> before!
> Reviewed-by: Andrew Bartlett <abartlet at samba.org>
> Thanks!
> Andrew Bartlett
> --
> Andrew Bartlett                       http://samba.org/~abartlet/
> Authentication Developer, Samba Team  http://samba.org
> Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list