[PATCHES] CTDB - fix a flaky test

Amitay Isaacs amitay at gmail.com
Wed Jul 2 21:55:13 MDT 2014


On Wed, Jul 2, 2014 at 8:04 PM, Martin Schwenke <martin at meltin.net> wrote:

> 2 patches:
>
> * ctdb-scripts: Always print footer when debugging hung script
>
>   There shouldn't be an early exit for the "init" event.  Just make the
>   "ctdb scriptstatus" call conditional.
>
>   While here, move the comment about only running a single instance to
>   be near locking code.  The comment is more useful there.
>
> * ctdb-tests: Fix racy test for debugging hung scripts
>
>   Debugging can still be running when a monitor event times out and
>   scriptstatus output changes.
>
>   When debugging a hung script to a log file, write to a temporary file
>   and move the temporary file over the log file when done.  The test
>   then waits for the log file to appear.
>
> The first patch just makes the 2nd patch possible by removing an early
> exit.
>
> Please review and push if OK.
>
> These patches are in my ctdb-test branch:
>
>
> http://git.samba.org/?p=martins/samba.git;a=shortlog;h=refs/heads/ctdb-test
>
> peace & happiness,
> martin
>

Pushed to autobuild.

Amitay.


More information about the samba-technical mailing list