[PATCH] Second chunk of parameter internal variable renames

Andrew Bartlett abartlet at samba.org
Fri Jan 24 16:24:32 MST 2014

On Fri, 2014-01-24 at 15:14 -0800, Jeremy Allison wrote:
> On Fri, Jan 24, 2014 at 10:09:30PM +1300, Andrew Bartlett wrote:
> > Alexander or Christian (or anyone else on the team interested),
> > 
> > Could you possibly review this second chunk of internal loadparm rename
> > patches for me?
> > 
> > These patches are part of our branch at
> > git://git.catalyst.net.nz/samba.git polished-param2
> Hi Andrew,
> I really tried hard to review+push these for you
> ('cos the look completely boilerplate and safe
> to me) but unfortunately this first one depends
> on a missing patch - the patch matching algorithm
> fails in lib/param/param_functions.c as the
> FN_LOCAL_XXXX text doesn't match on the first
> change. The second and subsequent patchsets
> then have the same problem :-(.
> Can you split out all the changes to the
> CamelCase -> camel_case parameters into
> one (large) set of patches patchset and
> I'll review them all in one go. I think
> that's the easiest way to stop running
> into silly gotcha's like this and get
> the rename in.

Certainly.  You probably didn't get the one I send Nadya, and it all
fell down from there.  See attached for the full patch. 


Andrew Bartlett

Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

-------------- next part --------------
A non-text attachment was scrubbed...
Name: param-rename-only.patch
Type: text/x-patch
Size: 677324 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140125/1b21491b/attachment-0001.bin>

More information about the samba-technical mailing list