[PATCH] Fix the last of the defaults and include a test to check them

Andrew Bartlett abartlet at samba.org
Fri Jan 31 13:05:34 MST 2014


On Fri, 2014-01-31 at 21:01 +0100, Michael Adam wrote:
> Good morning, Andrew! :-)
> 
> On 2014-02-01 at 08:49 +1300, Andrew Bartlett wrote:
> > On Fri, 2014-01-31 at 11:51 +0100, Michael Adam wrote:
> > > On 2014-01-31 at 23:41 +1300, Andrew Bartlett wrote:
> > > >
> > > > Did you have the 'use XML entities' patches in your series?  (They are
> > > > needed to get the paths correct).  
> > > 
> > > No. Where do I get them? Your param-after-reviewed branch?
> > > If you point me to the patchset needed in addition to the
> > > docs.py-uses ElementTree patch, I will give it another shot.
> > 
> > Garming posted a corrected patch set to the list yesterday as:
> > 
> > Re: [PATCH] Change smb.conf.5 build to use XML entities to get
> > always-correct default paths
> > 
> > These addressed Jelmer's suggestion that dynconfig wasn't a great XML
> > namespace, and is otherwise ready for master.
> > 
> > The attached series I've tested.
> 
> Ok, is there a branch with that state?

param-for-docs-test-only

> Is that the same state as Garming's patcheset above?

Yes, but I made sure to include a later patch to ensure that
parameters.all.xml is always built, even if we can't build manpages, so
that the test can work on all platforms. 

> > Also still pending is my (large) param-docs-metadata branch.
> >
> > Let me know if you want that in patch form, it never seemed to
> > get to the mailing list due to it's size.
> 
> No worries, pointers to branches are more convenient for me.

I've just re-pushed all the outstanding branches. 

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba




More information about the samba-technical mailing list