[PATCH] build: warn about mixed declarations and code

[Guenther Deschner]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Good point, David,

Reviewed-by: Guenther Deschner <gd at samba.org>

Thanks,
Guenther

On 31/01/14 16:43, David Disseldorp wrote:
> Attempt to use the -Wdeclaration-after-statement cflag when
> building in developer mode.
> 
> Signed-off-by: David Disseldorp <ddiss at samba.org> --- 
> buildtools/wafsamba/samba_autoconf.py | 2 +- 1 file changed, 1
> insertion(+), 1 deletion(-)
> 
> diff --git a/buildtools/wafsamba/samba_autoconf.py
> b/buildtools/wafsamba/samba_autoconf.py index fe110bd..e14f9cd
> 100644 --- a/buildtools/wafsamba/samba_autoconf.py +++
> b/buildtools/wafsamba/samba_autoconf.py @@ -640,7 +640,7 @@ def
> SAMBA_CONFIG_H(conf, path=None):
> 
> if Options.options.developer: # we add these here to ensure that
> -Wstrict-prototypes is not set during configure -
> conf.ADD_CFLAGS('-Wall -g -Wshadow -Werror=strict-prototypes
> -Wstrict-prototypes -Werror=pointer-arith -Wpointer-arith
> -Wcast-align -Werror=write-strings -Wwrite-strings
> -Werror-implicit-function-declaration -Wformat=2 -Wno-format-y2k
> -Wmissing-prototypes -fno-common -Werror=address', +
> conf.ADD_CFLAGS('-Wall -g -Wshadow -Werror=strict-prototypes
> -Wstrict-prototypes -Werror=pointer-arith -Wpointer-arith
> -Wcast-align -Werror=write-strings -Wwrite-strings
> -Werror-implicit-function-declaration -Wformat=2 -Wno-format-y2k
> -Wmissing-prototypes -fno-common -Werror=address
> -Wdeclaration-after-statement', testflags=True) 
> conf.ADD_CFLAGS('-Wcast-qual', testflags=True) 
> conf.env.DEVELOPER_MODE = True
> 


- -- 
Günther Deschner                    GPG-ID: 8EE11688
Red Hat                         gdeschner at redhat.com
Samba Team                              gd at samba.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlLrxzoACgkQSOk3aI7hFojqhACfR/V6tw8dCWOxKC1F11YzN6dS
TZgAoJMdV10KzE38ozjOooNW13WS54VF
=hhiE
-----END PGP SIGNATURE-----