[PATCH] Fix the last of the defaults and include a test to check them

[Michael Adam]

On 2014-01-31 at 23:41 +1300, Andrew Bartlett wrote:
> On Fri, 2014-01-31 at 10:58 +0100, Michael Adam wrote:
> > 
> > I have reviewed them and all doc and loadparm changes look
> > reasonable and good so far.
> 
> Great!
> 
> > But the new docs.py script fails the "samba.tests.docs"
> > test: It seems it does not get any of the parameters
> > from the docs with the ElementTree...
> > 
> > "AssertionError: Parameters that are in the implementation but undocumented:"
> >  lists _all_ parameters.
> 
> That's very, very odd.  
> 
> > The error I am seeing is also different on two different systems:
> > On our autobuild box (ubuntu 10.04) I see a plain error.
> > 
> > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > UNEXPECTED(failure): samba.tests.docs.SmbDotConfTests.test_undocumented
> > REASON: _StringException: Content-Type: text/x-traceback;charset=utf8,language=python
> > traceback
> > 238B
> > Traceback (most recent call last):
> >   File "/memdisk/obnox/x/b829955/samba/bin/python/samba/tests/docs.py", line 169, in test_undocumented
> >     "Parameters that are in the implementation but undocumented:"))
> > AssertionError: Parameters that are in the implementation but undocumented:
> > 
> >     -valid
> >     NIS homedir
> >     abort shutdown script
> >     ...
> >     write ok
> >     write raw
> >     writeable
> >     wtmp directory
> > 0
> > 
> > FAILED (1 failures, 0 errors and 0 unexpected successes in 0 testsuites)
> > 
> > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > 
> > 
> > On my laptop (ubuntu 13.10, I see  garbage output after the above
> > message (uninitialized memory?...) and apparently the error is not
> > correctly caught. The test continues with the unknown test and fails
> > again:
> 
> I can at least put your mind and sanity to rest regarding the weird
> output.  This is an artefact of the subunit2 protocol, and it varies
> depending on the version of the subunit packages installed on your
> system.
 
> The filters we use should hide these details, but something doesn't
> quite work right.  At least you can be assured it's nothing unexpected.

Ok, ... not 100% comforting though. ;-)

> > I guess I will look a little bit, but probably push the patches
> > without the docs.py update.
> 
> Thanks!

These are in autobuild now.

> Did you have the 'use XML entities' patches in your series?  (They are
> needed to get the paths correct).  

No. Where do I get them? Your param-after-reviewed branch?
If you point me to the patchset needed in addition to the
docs.py-uses ElementTree patch, I will give it another shot.

Cheers - Michael


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 215 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140131/202fd281/attachment.pgp>