[PATCH 3/3] build: find FILE_OFFSET_BITS via array

Andrew Bartlett abartlet at samba.org
Fri Jan 31 03:39:59 MST 2014

On Fri, 2014-01-31 at 07:07 -0300, Gustavo Zacarias wrote:
> On 01/30/2014 07:01 PM, Andrew Bartlett wrote:
> > Can you put that bit of maths in the commit message, and in a comment
> > above each use, just so folks don't have to stare at it next time we
> > come across it?
> > 
> > Then yes, improving the other tests would be a good idea. 
> Done, sent a V2 patch.
> With these 3 patches only 2 fixes remain to cross-compile:
> 1) Cross-compile bundled heimdal tools (asn1_compile & compile_et).
> This would require modifying waf itself from a quick look to allow for
> hostcc tasks @ buildtools/wafadmin/Tools/cc.py from a quick look.
> I don't know if/how much you diverged from upstream waf and if you're
> willing to take this approach so i'm waiting for a little feedback
> before going that way.

We have diverged on a number of points, but would like to know that any
issues we fix are improved upstream, so if we re-sync we don't loose the
fix.  That is, further divergence isn't a show-stopper, whereas this
issue is a major concern to a number of our vendors. 

> An alternative would be to fix external heimdal builds or (what i'm
> doing at the moment) just use external asn1_compile and compile_et tools
> with the bundled one.
> 2) Don't import python_* from distutils.
> Not cross-compile friendly at all.
> >From previous discussion a possibility was to fetch those from the
> cache, but that is a bit problematic for automation and somewhat dirty.
> There's another possibility:
> At the moment python-config is being used to get the includes, and since
> only python_LIBDIR and python_LDFLAGS are polluting the build with
> non-cross libraries those could be imported from python-config as well.
> Of course this won't work with a barebones python2-config since it's
> made in... python :) But i've backported python3.4's shell
> implementation for python2.7 and it works like a charm.
> Again this means diverging a bit from vanilla waf, but it's a small
> patch of wafadmin/Tools/python.py

I agree we should treat python no differently any other pkg-config based
dep, if we possibly can.  Let's see your patches and work from there. 

> What would you guys like regarding this two missing points?
> I'll proceed with making a cross-friendly sizeof too to reduce the cache
> answers needed, that's a bonus ;)


Andrew Bartlett

Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list