[PATCH] CTDB fixes

Martin Schwenke martin at meltin.net
Thu Jan 30 22:03:37 MST 2014


On Fri, 31 Jan 2014 15:18:25 +1100, Amitay Isaacs <amitay at gmail.com>
wrote:

> Here are some fixes to the event status handling code.
> 
> The patches are also available in my ctdb-wip branch.
> 
>    http://git.samba.org/?p=amitay/samba.git;a=shortlog;h=refs/heads/ctdb-wip
> 
> Please review and push if ok.

As discussed, I've pushed these 2:

0001-ctdb-daemon-Return-negative-status-only-if-there-are.patch
0004-ctdb-doc-Fix-usage-string-for-ctdb-readkey-writekey.patch

However, these aren't necesary:

* 0002-ctdb-daemon-Overall-status-of-events-should-check-st.patch

  The break that both of us independently and incorrectly kept reading
  as breaking from the loop actually breaks from the switch.  :-)

* 0003-ctdb-daemon-Check-the-status-of-scripts-only-for-exe.patch

  The status is in an array that is allocated using talloc_zero(),
  so it doesn't matter if the loop walks to the end of the array since
  the extra items won't affect the result.

peace & happiness,
martin


More information about the samba-technical mailing list