[PATCH] Fix the last of the defaults and include a test to check them

Garming Sam garming at catalyst.net.nz
Thu Jan 30 16:22:00 MST 2014


On 30/01/14 17:21, Garming Sam wrote:
> On 30/01/14 10:06, Michael Adam wrote:
>> Alright. I will try to keep reviewing these.
>>
>> Cheers - Michael
>>
> Here's a few more. This has the last of the renames I believe, which 
> didn't work on their own before.
>
> For printer name, it needed a patch which changed the function from 
> being static.
>
> The other dependent patch which I have here, is changing the security 
> default in s3 to AUTO instead of USER. In lib/param, it was always 
> already set to AUTO and in the docs, it says that the default should 
> be AUTO. With AUTO, it should act as USER unless the server role has 
> been set.
>
>
> Cheers,
>
> Garming Sam

This set of patches goes on top of the last of the renames and the 
entities patches.

It's the last set of patches needed to fix the defaults and includes the 
updated docs.py script. The new script compares the output of testparm 
to the docs to ensure the defaults are correct, so this should hopefully 
try to prevent deviations in the future.

The reason some of these are last is because they are the ones that 
actually make notable changes.



Cheers,

Garming Sam
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-lib-param-set-default-for-valid-parameter.patch
Type: text/x-patch
Size: 973 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140131/4f33b841/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-s4-resolve-Add-lmhosts-support-into-the-source4-name.patch
Type: text/x-patch
Size: 5824 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140131/4f33b841/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-lib-param-change-name-resolve-order-to-include-lmhos.patch
Type: text/x-patch
Size: 1011 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140131/4f33b841/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-docs-change-hard-coded-default-of-nsupdate-command-t.patch
Type: text/x-patch
Size: 837 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140131/4f33b841/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-lib-param-Fix-default-of-usershare-path-to-match-doc.patch
Type: text/x-patch
Size: 867 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140131/4f33b841/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-lib-param-Fix-default-of-panic-action-to-match-s3.patch
Type: text/x-patch
Size: 919 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140131/4f33b841/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-lib-param-Fix-default-of-smb-passwd-file-to-match-s3.patch
Type: text/x-patch
Size: 886 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140131/4f33b841/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-lib-param-Fix-default-of-logon-home-to-match-s3.patch
Type: text/x-patch
Size: 859 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140131/4f33b841/attachment-0007.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0009-lib-param-Fix-default-of-logon-path-to-match-s3.patch
Type: text/x-patch
Size: 850 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140131/4f33b841/attachment-0008.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0010-lib-param-Fix-default-of-printjob-username-to-match-.patch
Type: text/x-patch
Size: 856 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140131/4f33b841/attachment-0009.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0011-lib-param-change-min-wins-ttl-default-to-be-consiste.patch
Type: text/x-patch
Size: 1061 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140131/4f33b841/attachment-0010.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0012-lib-param-change-server-max-protocol-to-be-consisten.patch
Type: text/x-patch
Size: 1135 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140131/4f33b841/attachment-0011.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0013-s3-param-Remove-compilation-conditional-for-setting-.patch
Type: text/x-patch
Size: 1083 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140131/4f33b841/attachment-0012.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0014-docs-adjust-the-defaults-for-list-parameters-to-incl.patch
Type: text/x-patch
Size: 3497 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140131/4f33b841/attachment-0013.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0015-selftest-updated-docs.py-script.patch
Type: text/x-patch
Size: 8537 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140131/4f33b841/attachment-0014.bin>


More information about the samba-technical mailing list