[PATCH] some fixes for waf issues

Christian Ambach ambi at samba.org
Tue Jan 28 14:11:30 MST 2014


Hi Andrew,

Am 24.01.14 00:47, schrieb Andrew Bartlett:
> Can you take a look at:
>
> https://build.samba.org/build.cgi/build/fac539285006f64edc1c44176cffc5e6435bd116
>
> It seems that we may need to fix gettext/iconv stuff some more on HP-UX.

Looks like my Python knowledge is still too limited.
What is the problem with these lines?

oldflags = conf.env['EXTRA_LDFLAGS'];
conf.env['EXTRA_LDFLAGS'].extend(["-liconv"])
[...]
conf.env['EXTRA_LDFLAGS'] = oldflags

Looking at the logs, EXTRA_LDFLAGS still seems to contain "-liconv" as
if oldflags was not a copy, but a reference.
Or am I getting this wrong?

Cheers,
Christian


More information about the samba-technical mailing list