[PATCH] RFC debug detect winbindd version mismatches
Volker.Lendecke at SerNet.DE
Mon Jan 27 07:36:35 MST 2014
On Mon, Jan 27, 2014 at 02:25:09PM +0000, Noel Power wrote:
> > I'm not opposed to this feature. Question: Is there a way to
> > do this without a global variable?
> everything is possible :-)
> > Maybe with a special call
> > that queries the currently available interface version
> unfortunately 'winbind_open_pipe_sock' has a version request as part of
> the connection setup, if the version check fails then then you have no
> chance to get the result of a subsequent version request (the way the
> code currently is written)
Well, then rewrite the code...
You might factor out the version retrieval and call that
from a different path. I know that wb_common is a big mess
which needs cleaning up. I've tried to make that properly
async at some point but gave up.
> yup, understood, wasn't completely in love with the solution myself but
> seemed the easiest less impactful way to achieve this (mostly debug
> relevant) change, I can rewrite this by changing
> winbind_open_pipe_sock/winbind_read_sock/winbind_write_sock (and
> associated call chain) if the consensus is that it is necessary
Not sure about consensus, I'm just uttering my personal
opinion here. I could not even block the global variable,
but I would just like to not see that go in this way.
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
More information about the samba-technical