Remove dead code from plaintext auth case (impacting on AFS, DCE/DFS, OSF1, HP-UX and others)

[Andrew Bartlett]

I was looking to see if my request to Andreas for an auth_pam and
auth_passwd was reasonable, and saw some code that could be cleaned up,
which might make de-tangling the PAM from the not-PAM case a more
reasonable request.

The attached patches remove dead code that used to support AFS, DCE/DFS
and a number of other systems.  None of these survived the transition to
WAF.  

This post, by Yannick Bergeron indicates that PAM covers the DCE/DFS use
case:
https://lists.samba.org/archive/samba-technical/2013-May/092567.html

This does not address the actually useful use case of
--with-fake-kaserver, that is bug
https://bugzilla.samba.org/show_bug.cgi?id=9916 and remains open.

There is a lot of dead code here, and clearly a lot missed the WAF
transition, which is unfortunate.  That said, if someone wishes to
revive this, we need test systems and tested patches for WAF to
implement the configure checks, as it isn't safe to just blindly copy
the logic across from the old autoconf build. 

The purpose of these patches is just dead code elimination.  If we
wanted to wait longer for feedback from our 4.0 waf and 4.1 users who
are already without this feature, we could, but my instinct is that the
number of users using plaintext authentication and using these systems
is very, very small.  But if they exist, then they will be the folks who
will best be able to confirm any patch to restore this is actually
correct.

Please comment/review/push.

Thanks,

Andrew Bartlett
-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-auth-Remove-static-variable-ths_user-from-password_c.patch
Type: text/x-patch
Size: 3962 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140122/890e4861/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-auth-Remove-unused-PASSWORD_LENTH-macro-from-pass_ch.patch
Type: text/x-patch
Size: 869 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140122/890e4861/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-auth-Remove-dfs_auth-from-pass_check.c-and-s4-s-auth.patch
Type: text/x-patch
Size: 9917 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140122/890e4861/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-auth-Remove-afs_auth-from-pass_check.c-and-s4-s-auth.patch
Type: text/x-patch
Size: 2403 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140122/890e4861/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-auth-Remove-plaintext-OSF1-password-support.patch
Type: text/x-patch
Size: 4345 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140122/890e4861/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-auth-Remove-support-for-plaintext-auth-on-systems-th.patch
Type: text/x-patch
Size: 1603 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140122/890e4861/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-auth-Remove-linux_bigcrypt-support-from-pass_check.c.patch
Type: text/x-patch
Size: 2511 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140122/890e4861/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-auth-Remove-USE_BOTH_CRYPT_CALLS-block-from-pass_che.patch
Type: text/x-patch
Size: 3181 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140122/890e4861/attachment-0007.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0009-auth-Remove-support-for-HAVE_TRUNCATED_SALT-from-pas.patch
Type: text/x-patch
Size: 26751 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140122/890e4861/attachment-0008.bin>