[PATCH]Do not open the dir for purely attr/acl related mask

Jeremy Allison jra at samba.org
Tue Jan 21 14:29:25 MST 2014

On Tue, Jan 21, 2014 at 12:35:53PM -0700, Christof Schmitt wrote:
> On Tue, Jan 14, 2014 at 11:55:59AM +0530, Abhidnya S Joshi wrote:
> > Hi list,
> > 
> > Please find the attached patch which modifies open_directory call to get 
> > rid of unnecessary open. 
> > As Samba always opens the directory, dir operations always require 
> > READ_DATA/read set on dir which is not true with Windows.
> > The example operation is set ACL on dir by owner when there are zero ACLs. 
> > This way is already present for files.
> > Please let me know suggestions/comments
> > 
> > I am also trying to write torture test around this.
> This looks good to me. It also matches the 'stat open' for files, so
> having a similar codepath for directories makes sense.

+1 from me also. Abhidnya, can you resend the patch
with your 'Signed-off-by:' tag ? Alternatively reply
with a +1 on the attached version and I'll push to
autobuild for you.



More information about the samba-technical mailing list