Default startup message log level and systemd

[Lars Müller]

On Fri, Jan 17, 2014 at 08:44:46AM +1300, Andrew Bartlett wrote:
> On Thu, 2014-01-16 at 19:56 +0100, Lars Müller wrote:
> > 
> > while starting nmbd, smbd, and winbindd we see at startup
> > 
> > Jan 16 18:51:22 hip smbd[31452]: [2014/01/16 18:51:22.487860,  0] ../source3/smbd/server.c:1278(main)
> > Jan 16 18:51:22 hip smbd[31452]: standard input is not a socket, assuming -D option
> > 
> > The systemd service files in use are from the packaging/systemd/
> > directory.
> > 
> > I suggest to assign to these two DEBUG statements a log level of 3 to
> > avoid the logging of these messages.
> 
> The other option would be to always use -D in the systemd scripts.

Oh, it would be quite easy to fill /etc/sysconfig/samba with the fitting
default.  But I consider the current log level of 0 just wrong.

Why?

The current code already is able to handle all correctly.  !is_daemon &&
!is_a_socket(0) and we're starting as daemon.

To me it's more elegant if we don't need to pass any additional argument
to silent a program.

See also some lines further in the code.  There we log 'Becoming a
daemon.' as log level 3 message too.

Cheers,

Lars
-- 
Lars Müller [ˈlaː(r)z ˈmʏlɐ]
Samba Team + SUSE Labs
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140117/64460c3f/attachment.pgp>