[PATCHES] More logging for dbwrap_ctdb

Volker Lendecke Volker.Lendecke at SerNet.DE
Wed Jan 15 00:59:54 MST 2014

On Tue, Jan 14, 2014 at 03:45:13PM -0700, Christof Schmitt wrote:
> On Tue, Jan 14, 2014 at 06:56:44PM +0100, Volker Lendecke wrote:
> > On Mon, Jan 13, 2014 at 04:36:20PM -0700, Christof Schmitt wrote:
> > > > We could lookup the parameters in db_open_ctdb and store the settings in
> > > > db_ctdb_ctx. Would that be enough?
> > 
> > Yes, that would definitely do it. A few lp_parm calls per db
> > connect is certainly fine.
> Ok, i added that as a new patch in the attached patch series. I also
> added another patch to always print milliseconds for consistency.

Yes, that's exactly what I had in mind. One minor nit-pick:

[1869/4138] Compiling source3/lib/g_lock.c ../source3/lib/dbwrap/dbwrap_ctdb.c: In Funktion »fetch_locked_internal«:
../source3/lib/dbwrap/dbwrap_ctdb.c:1054:17: Warnung: Deklaration von »ctdb_start« überdeckt eine globale Deklara
tion [-Wshadow]
../../../../home/vlendec/git/inst/include/ctdb_client.h:102:5: Warnung: verdeckte Deklaration ist hier [-Wshadow]

Christof should be able to understand the German... :-)

Can we rename the ctdb_start variable to fix this minor



SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

More information about the samba-technical mailing list