master4-schannel-ok

[Andrew Bartlett]

On Sat, 2014-01-11 at 17:22 +0100, Stefan (metze) Metzmacher wrote:
> Hi Andrew,
> 
> can you review the attached patches from my master4-schannel-ok
> branch.
> 
> It seems that the use computer name in ServerAuthenticate must be at most
> 15 characters long.

My concerns are:
 - how does this (if at all) interact with the NTLMv2 computer name
check?
 - shouldn't we be stopping the netbios name being more than 15
characters earlier?
 - the hash isn't limited to ascii chars, is sending binary really a
great idea, if it ends up in a windows event log etc?

Andrew Bartlett

-- 
Andrew Bartlett
http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba