[PATCHES] some new tevent features

Stefan (metze) Metzmacher metze at samba.org
Mon Jan 13 13:11:42 MST 2014


Hi Volker,

>>>> static int smbXcli_req_destructor(struct tevent_req *req)
>>>> static int fncall_destructor(struct tevent_req *req)
>>>> static int tldap_msg_destructor(struct tevent_req *req)
>>>
>>> Thanks for checking. Maybe I was a bit worried because 2 of
>>> those are mine ... :-)
>>
>> Can you review the attached patches?
> 
> Please don't push this patches yet, I'm currently debugging a possible
> problem...

There was a bug in the interaction with tevent_req_defer_callback()
and tevent_req_set_cleanup_fn().

This bug is fixed in the attached patchset (it's also a bit cleaner this
way).
We rely the tevent_req_state enum being sorted, we only trigger
the cleanup function once per state and remember the last state
and skip the cleanup function on the 2nd call.

metze
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tmp.diff
Type: text/x-diff
Size: 27924 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140113/86e4e37a/attachment.diff>


More information about the samba-technical mailing list