[PATCHES] some new tevent features

Stefan (metze) Metzmacher metze at samba.org
Sat Jan 11 02:52:53 MST 2014


Am 12.12.2013 13:37, schrieb Volker Lendecke:
> On Wed, Dec 11, 2013 at 06:45:45PM +0100, Stefan (metze) Metzmacher wrote:
>> Hi Volker,
>>
>>>>> >From 0a2bce1393e4c8e65b8f69c051c9a236319584b0 Mon Sep 17 00:00:00 2001
>>>>> From: Stefan Metzmacher <metze at samba.org>
>>>>> Date: Fri, 27 Sep 2013 03:41:29 +0200
>>>>> Subject: [PATCH 04/14] tevent: add/use tevent_req_destructor
>>>>>
>>>>> This makes sure we call tevent_req_received(req) on talloc_free()
>>>>> and cleanup things in a defined order.
>>>>
>>>> Are we 100% sure that no tevent_req user already does this?
>>>
>>> I don't understand that question.
>>
>> Ok, I got it, we have:
>>
>> static int smbXcli_req_destructor(struct tevent_req *req)
>> static int fncall_destructor(struct tevent_req *req)
>> static int tldap_msg_destructor(struct tevent_req *req)
> 
> Thanks for checking. Maybe I was a bit worried because 2 of
> those are mine ... :-)

Can you review the attached patches?

metze
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tmp.diff
Type: text/x-diff
Size: 27912 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140111/98faaf07/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140111/98faaf07/attachment.pgp>


More information about the samba-technical mailing list