Get rid of Py_RETURN_NONE wrappers
jelmer at samba.org
Wed Jan 8 21:17:03 MST 2014
On Thu, Jan 09, 2014 at 09:01:38AM +1300, Andrew Bartlett wrote:
> On Wed, 2014-01-08 at 15:52 +0100, Matthias Dieter Wallnöfer wrote:
> > Hi Jelmer,
> > during "./configure" I noticed the various Python release checks. It
> > turns out that we now require always at least release 2.4 for all
> > components (2.5 for s4).
> > This encouraged me to have a look at the various substituion macros
> > which we have developed over time. And indeed, the Py_RETURN_NONE
> > wrappers are not needed any longer
> > (http://www.python.org/doc//current/c-api/none.html) - so I would
> > strongly propose to remove them:
> > https://git.samba.org/samba.git/?p=mdw/samba.git;a=commitdiff;h=62937731e052775c1541c17e89254ce7db7e06db
> I'll wait for Jelmer, but I agree. I wonder what other things do we
> have or avoid for python 2.4?
The main ones are a handful of new standard library functions, and the introduction of the
"with" statement. The latter can be quite useful in some cases.
More information about the samba-technical