[PATCH] Fix defaults in docs, testparm and samba-tool testparm to match

Andrew Bartlett abartlet at samba.org
Wed Jan 8 16:36:26 MST 2014


On Wed, 2014-01-08 at 17:12 +1300, Andrew Bartlett wrote:
> Garming and I continue to work on the technical debt in our loadparm
> systems. 
> 
> This patch series is at:
> 
> git://git.samba.org/abartlet/samba.git param-default
> 
> http://git.samba.org/?p=abartlet/samba.git/.git;a=shortlog;h=refs/heads/param-default
> 
> In that tree, we have the renames we did, and a significant new effort
> to fix the lingering issue from Samba 4.0, where the defaults in our two
> loadparm systems did not match each other.  
> 
> Garming is working on an automated test to validate the three sources
> are in sync, and this is the early output.  A large number of errors
> were detected, and fixed.  In general, the s3 defaults are the correct
> ones, and are used everywhere else, but the rationale for each change is
> explained in each commit. 
> 
> The test tool itself (improvements to docs.py) will be published soon,
> and is now based on parsing the parameters.all.xml using python's
> internal XML parser, rather than regular expressions.
> 
> We appreciate it is difficult to review and push a 400-patch series, but
> we would appreciate exactly that.  Where practical, the patches are
> small distinct changes in each commit.  It is currently undergoing a
> private autobuild.

With one change (dropping the change default for unix extensions in
lib/param), this now passes a private autobuild.  

We continue to work to fix other defaults, but it will be more
manageable if we can get this set of changes in first.  In particular,
we have separately a list of defaults that need discussion (now also
including 'unix extensions'). 

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett
http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba






More information about the samba-technical mailing list