[PATCH] group_mapping: Avoid a talloc

Andrew Bartlett abartlet at samba.org
Wed Jan 8 15:04:13 MST 2014


On Wed, 2014-01-08 at 22:17 +0100, Volker Lendecke wrote:

> By the way, one of the hottest routines is talloc_free these
> days. Every talloc has to go through that, even if it comes
> from a talloc_pool.

Indeed, I've seen the same thing when doing performance work on the
inner loops in ldb.  That, and the various checks in
talloc_chunk_from_ptr take a surprisingly large amount of our runtime
according to perf.  I just disagree about doing this in the general
case.

Andrew Bartlett

-- 
Andrew Bartlett
http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba






More information about the samba-technical mailing list