[PATCH] group_mapping: Avoid a talloc

Volker Lendecke Volker.Lendecke at SerNet.DE
Wed Jan 8 13:54:48 MST 2014

On Thu, Jan 09, 2014 at 09:22:42AM +1300, Andrew Bartlett wrote:
> I can see the argument for stuff in tight inner loops, but I'm very,
> very wary of going back to fixed length strings everywhere.  What's the
> whole argument of talloc_pool() that this was fast enough, without all
> the risks of fixed length strings?
> There is a great value in consistency of talloc-based string handling,
> because it means that we can realistically examine our fixed length
> string use, because it's rare, not used anywhere we might save a cycle
> or two outside the hot path.
> In short, I don't like where I see this headed, and I think we should
> consider that.

When was the last time you did performance work?


SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

More information about the samba-technical mailing list