Winbindd using 100% of CPU. Any solution?
realrichardsharpe at gmail.com
Mon Jan 6 21:41:07 MST 2014
On Mon, Jan 6, 2014 at 3:41 PM, Jeremy Allison <jra at samba.org> wrote:
> Ok, I chatted with Richard and the underlying problem
> is a disconnect with setup_domain_child() being called on
> domain structs that have already been added into the list,
> instead of only being called when a struct is allocated
> and added into the list.
> The solution to that is to move the call to setup_domain_child()
> inside of the add_trusted_domain() function, so it is
> only called when a new domain struct is added.
> Attached is a small patchset that does this, and
> also keeps the logic identical by also moving the
> setting of 'domain->primary = true' inside
> add_trusted_domain() to ensure the current
> ordering of variable changes is the same.
> That could also be done by adding a 'bool primary'
> parameter to the add_trusted_domain() parameter
> list, but I know how much Volker hates new arbitrary
> bool parameters, so I though it was cleaner to
> do it this way :-).
> I'm pretty sure this is the correct way to
> fix the logic, but getting a reproducer (or
> a site that can reproduce and test the patches)
> will be needed.
> Please review + test. I'll also attach this
> to the bug report (https://bugzilla.samba.org/show_bug.cgi?id=10358).
I think it looks good, but would like a comment above
add_trusted_domain about the early return and what we do etc.
I will have a chance to test this tomorrow on the same site where the
problem first arose.
More information about the samba-technical