[PATCH] Re: netlogon_creds_cli_validate() in master4-schannel

[Andrew Bartlett]

On Mon, 2014-01-06 at 11:54 +1300, Andrew Bartlett wrote:
> On Sun, 2014-01-05 at 23:46 +0100, Stefan (metze) Metzmacher wrote:
> > Am 05.01.2014 23:13, schrieb Andrew Bartlett:
> > > On Sun, 2014-01-05 at 13:55 +0100, Stefan (metze) Metzmacher wrote:
> > >> Hi Andrew,
> > >>
> > >>>> No, I just need to retest with this code.
> > >>>>
> > >>>> You could try to fix the flakey tests we currently have...:-)
> > >>>
> > >>> This fixes samba.tests.docs
> > >>
> > >> Thanks!
> > >>
> > >> I've added rpc header signing support and
> > >> dcerpc_sec_verification_trailer support (s3 client only for now) to my
> > >> https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master4-schannel-ok
> > >> branch.
> > >>
> > >> I'll retest this against Samba 3.0, 3.2, 3.4, ...
> > >> and windows NT4 sp6a, 2000, ...
> > >>
> > >> If the tests are ok, we can finally push to master.
> > > 
> > > One final thing (sorry), but if you can push the docs with the new
> > > parameters in a single commit, then the result will be bisect-able
> > > across a full make test. 
> > 
> > Ok, I'll try to let every commit pass autobuild.
> 
> Thanks.
> 
> > Can I have your review on the new patches?
> 
> I'm reading over that code now.  

Reviewed-by: Andrew Bartlett <abartlet at samba.org>

It's great to see how well this has worked with the gensec feature
handling, and good to see schannel merged back as just a gensec module,
rather than a distinct 'library'. 

Andrew Bartlett

-- 
Andrew Bartlett
http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba