[PATCH 2/2] dns: Extend tests for records with another type

Kai Blin kai at samba.org
Fri Feb 28 04:48:10 MST 2014


Add another check to the one added for bug #10471, for added paranoia

Signed-off-by: Kai Blin <kai at samba.org>
---
 python/samba/tests/dns.py | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/python/samba/tests/dns.py b/python/samba/tests/dns.py
index bac8dea..f2c5685 100644
--- a/python/samba/tests/dns.py
+++ b/python/samba/tests/dns.py
@@ -187,6 +187,20 @@ class TestSimpleQueries(DNSTest):
         self.assert_dns_opcode_equals(response, dns.DNS_OPCODE_QUERY)
         self.assertEquals(response.ancount, 0)
 
+        p = self.make_name_packet(dns.DNS_OPCODE_QUERY)
+        questions = []
+
+        name = "invalid-%s.%s" % (os.getenv('SERVER'), self.get_dns_domain())
+        q = self.make_name_question(name, dns.DNS_QTYPE_MX, dns.DNS_QCLASS_IN)
+        print "asking for ", q.name
+        questions.append(q)
+
+        self.finish_name_packet(p, questions)
+        response = self.dns_transaction_udp(p)
+        self.assert_dns_rcode_equals(response, dns.DNS_RCODE_NXDOMAIN)
+        self.assert_dns_opcode_equals(response, dns.DNS_OPCODE_QUERY)
+        self.assertEquals(response.ancount, 0)
+
     def test_two_queries(self):
         "create a query packet containing two query records"
         p = self.make_name_packet(dns.DNS_OPCODE_QUERY)
-- 
1.9.rc1



More information about the samba-technical mailing list