[PATCH] samba-tool dbcheck: handle missing objectClass

[Andrew Bartlett]

On Fri, 2014-02-28 at 10:00 +0100, Felix Botner wrote:
> > Do you have a test domain that demonstrates this issue, without
> > confidential data in it?  It would be great to upload such a domain into
> > our test framework, to ensure we correctly fix it.  (We have some
> > similar domains already, for example with the zero-guid issue).
> 
> Not at the moment, but i try to reproduce this in a test domain.
> What exactly do you need (an archiv of /var/lib/samba/)?
> 
> > If you are OK with the changed patch, please indicate so (I object to
> > silently changing a patch under someone else's authorship), and I'll get
> > a second team reviewer on this and so help it into master!
> 
> Sure, it's OK
> 
> > Can you get me the replPropertyMetaData for this and for
> > CN=2c4fcffe-f0c2-4e0f-b852-c9fe2805732f\0ADEL:60f25113-97be-4070-
> > b8e1-61289f8469df,CN=Deleted Objects,CN=Configuration,DC=sec,DC=lan
> 
> dn: CN=2c4fcffe-f0c2-4e0f-b852-c9fe2805732f\0ADEL:60f25113-97be-4070-
> b8e1-61289f8469df,CN=Deleted Objects,CN=Configuration,DC=sec,DC=lan
> replPropertyMetaData:: 
> AQAAAAAAAAALAAAAAAAAAAEAAgABAAAArkRiBwMAAADpCBli2rsTSp+iDBFXq3VvvkIAAAAAAADA3BEAAAAAADAAAgABAAAAKoVrBwMAAADpCBli2rsTSp+iDBFXq3VvJEUAAAAAAADA3BEAAAAAAKkAAgACAAAAKoVrBwMAAADpCBli2rsTSp+iDBFXq3VvJEUAAAAAAADA3BEAAAAAAAEACQACAAAAKoVrBwMAAADpCBli2rsTSp+iDBFXq3VvJEUAAAAAAADA3BEAAAAAACQACQACAAAAKoVrBwMAAADpCBli2rsTSp+iDBFXq3VvJEUAAAAAAADA3BEAAAAAACgACQACAAAAKoVrBwMAAADpCBli2rsTSp+iDBFXq3VvJEUAAAAAAADA3BEAAAAAADMBCQACAAAAKoVrBwMAAADpCBli2rsTSp+iDBFXq3VvJEUAAAAAAADA3BEAAAAAAA0DCQABAAAAKoVrBwMAAADpCBli2rsTSp+iDBFXq3VvJEUAAAAAAADA3BEAAAAAAA4DCQACAAAAKoVrBwMAAADpCBli2rsTSp+iDBFXq3VvJEUAAAAAAADA3BEAAAAAAAoICQABAAAAKoVrBwMAAADpCBli2rsTSp+iDBFXq3VvJEUAAAAAAADA3BEAAAAAAAMAAAACAAAAKoVrBwMAAADpCBli2rsTSp+iDBFXq3VvJEUAAAAAAADA3BEAAAAAAA==
> 
> > Do you have any data on which Samba versions this happens with?  I
> > strongly suspect that our deletion code is still broken.
> 
> cn=supergroup\0ADEL:84d4159b-4b1c-4b08-ba30-ded58028a0bd,CN=Deleted...:
> version: 4.1.0-1
> 
> CN=WIN-PC,CN=Computers,DC=abc,DC=ucs:
> version: 4.0.3-1
> 
> dn: CN=2c4fcffe-f0c2-4e0f-b852-c9fe2805732f\0ADEL:60f25113-97be...:
> version: 4.0.3-1

Are all the failing installations all pure Samba?

See attached for a potential fix, or if not a fix for this, a trap that
will find the other bug, but there is a serious one here due to
incorrect sorting that could easily cause attributes to be lost. 

Metze,

Can you look carefully at this for me?

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-dsdb-Ensure-to-sort-replPropertyMetaData-as-UNSIGNED.patch
Type: text/x-patch
Size: 1034 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140228/1edbe16a/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-dsdb-Further-assert-that-we-always-have-an-objectCla.patch
Type: text/x-patch
Size: 9458 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140228/1edbe16a/attachment-0001.bin>