[PATCH v3] vfs: propagate snapshot enumeration errors

Jeremy Allison jra at samba.org
Thu Feb 27 12:44:59 MST 2014


On Thu, Feb 27, 2014 at 07:46:14PM +0100, David Disseldorp wrote:
> The current FSCTL_GET_SHADOW_COPY_DATA/FSCTL_SRV_ENUMERATE_SNAPSHOTS
> handler squashes all non-ENOSYS errors into an NT_STATUS_UNSUCCESSFUL
> response.
> This commit ensures that all errors are propagated up to the client, to
> aid debugging.
> The Windows Explorer "Previous Versions" dialogue doesn't appear to
> distinguish between error codes. It displays "There are no previous
> versions available".
> 
> Signed-off-by: David Disseldorp <ddiss at samba.org>

LGTM - pushed to autobuild. Thanks !


More information about the samba-technical mailing list