[PATCH] vfs: propagate snapshot enumeration permissions errors

David Disseldorp ddiss at suse.de
Thu Feb 27 02:51:13 MST 2014

Hi Andrew,

On Thu, 27 Feb 2014 12:33:14 +1300, Andrew Bartlett wrote:

> On Thu, 2014-02-27 at 00:06 +0100, David Disseldorp wrote:
> > handler squashes all non-ENOSYS errors into an NT_STATUS_UNSUCCESSFUL
> > response.
> > This commit ensures that permissions errors are propagated up to the
> > client as NT_STATUS_ACCESS_DENIED, to aid debugging.
> > The Windows Explorer "Previous Versions" dialogue doesn't appear to
> > distinguish between error codes. It displays "There are no previous
> > versions available" in both cases.  
> Any particular reason not to use the generic mapping from unix error
> codes?

I only tested how the "Previous Versions" dialogue handled the
NT_STATUS_ACCESS_DENIED error code. That said, I don't expect other
error codes to be a problem, so can change it to call
map_nt_error_from_unix() if you'd prefer.

Cheers, David

More information about the samba-technical mailing list